search

microsoft / vscode-jupyter

VS Code Jupyter extension
https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter
MIT License
1.3k stars 293 forks source link

Why are there two Shift-Enter Key Bindings for Python/Powershell #7895

Closed jasonc-valve closed 3 years ago

jasonc-valve commented 3 years ago

Issue Type: Bug

Shift-Enter tries to run a python line from a python file but does so in powershell.

Is this possibly because I have both the powershell and python extenstions enabled maybe.

image

VS Code version: Code 1.58.2 (c3f126316369cd610563c75b1b1725e0679adfb3, 2021-07-14T22:10:15.214Z) OS version: Windows_NT x64 10.0.18363 Restricted Mode: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-7820X CPU @ 3.60GHz (16 x 3600)| |GPU Status|2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|63.68GB (41.09GB free)| |Process Argv|--crash-reporter-id 23fe7fa4-3b94-4f4a-b8cb-a11dc0a7629c| |Screen Reader|no| |VM|0%|
Extensions (6) Extension|Author (truncated)|Version ---|---|--- copilot|Git|1.2.1991 python|ms-|2021.6.944021595 vscode-pylance|ms-|2021.7.4 jupyter|ms-|2021.8.1013163132 remote-wsl|ms-|0.58.2 powershell|ms-|2021.6.2
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383cf:30185419 pythonvspyt678:30270856 pythonvspyt602:30300191 vspor879:30202332 vspor708:30202333 vspor363:30204092 pythonvspyt639:30300192 pythontb:30283811 pythonvspyt551cf:30311713 vspre833:30321513 pythonptprofiler:30281270 vshan820:30294714 vstes263cf:30335440 vscorecescf:30322572 pythondataviewer:30285071 vscus158:30321503 pythonvsuse255cf:30335482 vscod805cf:30301675 pythonvspyt200:30331937 vscextlang:30333561 binariesv615:30325510 vsccppwt:30329788 bridge0708:30335490 ```
DonJayamanne commented 3 years ago

I'm sorry for not getting back to you. I believe we have resolved this issue, please do let us know if this is not yet fixed in the latest version of VS Code 1.61

Even though multiple commands share the same keyboard shortcut, they don't run at the same time, based on some context (when clause), the two commands will not run.

Optionally you can change the keyboard shortcuts for the commands in VS Code.

Closing, as this isnt an issue, however if you believe you have issues, or still unresolved, please feel free to re-open this issue or create a new issue

jasonc-valve commented 3 years ago

Looks like it is working now. Will update if I run into any other problems. Thanks!