nklick commented 4 years ago

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

Accidentally deleted multiple cells by double clicking the garbage can icon in the top right corner of the cell.
Attempted to recover cell by pressing Z.

Actual behavior

No effect after pressing Z, so pressed again.
Entire notebook reverted to the state it was a week ago, causing internal user meltdown.
Shift-Z recovered notebook minus the recently deleted cells, meltdown halted, but ~two hours of work remains deleted.

Note: I am not using VSCode until this has been solved. It's insane that a double click can delete hours of work permanently.

Expected behavior

Z should recover recently deleted cells
Z should undo cell changes one change at a time, not an entire week's worth of changes

Your Jupyter and/or Python environment

Please provide as much info as you readily know

Jupyter server running: [Local] | Remote | N/A
Extension version: 2020.7.96456-xxx
VS Code version: 1.47.3
Setting python.jediEnabled: true | false (True? couldn't find it explicitly in settings)
Setting python.languageServer: [Jedi] | Microsoft | None
Python and/or Anaconda version: #.#.#
OS: Windows | [Mac] | Linux (distro):
Virtual environment: conda | [venv] | virtualenv | N/A | ...

Developer Tools Console Output

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

joyceerhl commented 4 years ago

Hi @nklick, sorry for the trouble and thank you for reporting this issue. This sounds like the undo stack got corrupted, but it seems like it might be difficult to repro, as I just tried undoing cell deletions locally and 'z' currently works for me. Would you mind providing more details about how this bug occurred? Did you have the cell selected when you were pressing 'z' (i.e. the side of the cell was highlighted in blue) without effect? Had you left the notebook open in a VS Code session for a week and recently come back to it?