search

microsoft / vscode-l10n

MIT License
66 stars 14 forks source link

New line characters not normalized #143

Closed TylerLeonhardt closed 11 months ago

TylerLeonhardt commented 12 months ago

image

Take a look at this big "To have a great conversation" string... that uses newlines in it and in the bundle, they are \r\n but on non-Windows we'll be asking for \n... so we need to normalize these newlines.

TylerLeonhardt commented 11 months ago

This is now done. fixed in https://github.com/microsoft/vscode-l10n/pull/146

One thing I wanted to call out is that this required another fix to our engineering system as we have our translated strings in a git repo and when that repo was checked out along side of the extension code, we were using a Windows machine which did autocrlf... causing the LFs to be checked out as CRLFs... this is fixed by running:

git config --global core.autocrlf input

in our pipeline before checking out the translated strings causing them to be checked out as LF.

TylerLeonhardt commented 11 months ago

verification:

just look at "to have a great conversation"