search

microsoft / vscode-languageserver-node

Language server protocol implementation for VSCode. This allows implementing language services in JS/TS running on node.js
MIT License
1.41k stars 320 forks source link

Support pulling diagnostics for notebooks too #1465

Closed rchiodo closed 1 month ago

rchiodo commented 2 months ago

Fixes https://github.com/microsoft/vscode-languageserver-node/issues/1464

Please let me know if this is acceptable. Wasn't sure if formatting was correct or if I did something weird in the testing.

I also tested this using the Pylance extension to verify I do receive pull diagnostics requests for notebooks in Pylance.

rchiodo commented 2 months ago

@dbaeumer do you see these automatically? Sorry wasn't sure if you saw this or not.

dbaeumer commented 2 months ago

Yes, I do but I was out sick last week :-(

dbaeumer commented 2 months ago

Great work. I highly appreciate the effort. See my comments. I am open for discussion since I might have missed some design choices as well.

dbaeumer commented 1 month ago

Looks good to me. Only one small request for change.

dbaeumer commented 1 month ago

@rchiodo thanks again for the great PR.