microsoft / vscode-languageserver-node

Language server protocol implementation for VSCode. This allows implementing language services in JS/TS running on node.js
MIT License
1.48k stars 325 forks source link

Support `isAI` property on `CodeAction` #1555

Open StellaHuang95 opened 2 months ago

StellaHuang95 commented 2 months ago

The Typescript team has added Copilot suggestions to various refactors in VS Code. To bring similar functionality to python code, Pylance has enabled the implement inherited abstract classes with Copilot code action through the Github Copilot extension for Python files.

To display the sparkle icon for the code action instead of the regular light bulb icon, the isAI property needs to be set to true on the codeAction.

Image

LSP doesn't support this API yet. Would it be possible for LSP to support the codeActionAI proposed API?

Is it as simple as adding the conversion logic to asCodeAction in protocolConverter.js? I'd be happy to send a PR if that's all it takes. Thanks!

dbaeumer commented 2 months ago

There is actually more to it:

Happy to help if you want to work on a PR for here and https://github.com/microsoft/language-server-protocol

StellaHuang95 commented 2 months ago

@dbaeumer I sent both PRs, let me know if you have any feedback. Thanks for the help😊

PRs are at: https://github.com/microsoft/vscode-languageserver-node/pull/1557 https://github.com/microsoft/language-server-protocol/pull/2020