microsoft / vscode-loader

An universal Asynchronous Module Definition (AMD) Loader developed primarily to load VSCode's sources.
Other
170 stars 55 forks source link

support loading scoped modules at runtime #10

Closed ggilmore closed 6 years ago

ggilmore commented 7 years ago

This adds functionality to support loading a scoped node package in a non-build context (e.g. using the yarn watch command, etc.).

Two questions:

  1. I don't know why the /** @class */ entries were added. I built the project using npm run watch-all. Do you know if that was the right command to use, or do I need to configure something else?

  2. Do you feel like this functionality needs testing. If so, could you point me in the direction of where/how to add it? I found the documentation regarding the testing structure to not be super helpful.

msftclas commented 7 years ago

CLA assistant check
All CLA requirements met.