microsoft / vscode-loader

An universal Asynchronous Module Definition (AMD) Loader developed primarily to load VSCode's sources.
Other
170 stars 55 forks source link

Normalize line endings #24

Closed SamB closed 5 years ago

SamB commented 5 years ago

Changes to make things safe for people who have core.autocrlf=true in their git settings, which is basically the default on Windows.

Unfortunately, this requires changes on (virtually) every line of files that use CRLF line terminators, so it' would be best to review this as quickly as possible so that I don't have to fix the merge conflicts too many times.

The git log -p --ignore-cr-at-eol command is useful for verifying that I haven't accidentally changed anything besides CRs at the ends of lines (as would happen if, for example, I had chosen the wrong merge resolution when rebasing these changes on top of any new commits).

(The --ignore-cr-at-eol flag is one of the diff-options, so you can use it with most of git's other diff-generating commands, too.)

alexdima commented 5 years ago

Thank you!