search

microsoft / vscode-loader

An universal Asynchronous Module Definition (AMD) Loader developed primarily to load VSCode's sources.
Other
170 stars 55 forks source link

String format should check number of args against placeholders to detect mismatches #31

Open dbaeumer opened 3 years ago

dbaeumer commented 3 years ago

The place to check is here: https://github.com/microsoft/vscode-loader/blob/cbe8f639e7e2ae8a0ede5da411555815158bd13e/src/nls.ts#L72

alexdima commented 3 years ago

@dbaeumer Do you want to look into doing this? I think you wrote the initial _format implementation.

dbaeumer commented 3 years ago

We are discussing whether @TylerLeonhardt takes over more so I asked him to look into it. Will assign to him for now.

TylerLeonhardt commented 3 years ago

I take a look at this next milestone probably.