microsoft / vscode-loader

An universal Asynchronous Module Definition (AMD) Loader developed primarily to load VSCode's sources.
Other
170 stars 55 forks source link

Remove unused fallback code path #32

Closed Andarist closed 3 years ago

Andarist commented 3 years ago

getElementsByTagName always return an HTMLCollection. So either this is not needed or the logic should fallback when the list of link elements is empty. I don't know what was the intention behind this so I've decided to just drop this since it's not working either way so most likely the other proposed solution is not needed by anyone.

alexdima commented 3 years ago

Thank you!