search

microsoft / vscode-makecode

A vscode.dev compatible extension for Microsoft MakeCode
MIT License
33 stars 6 forks source link

No delete button for Tiles #93

Open Sheila111 opened 1 year ago

Sheila111 commented 1 year ago

Describe the bug No delete button for Tiles

Steps to reproduce the behavior

  1. Navigate to https://arcade.makecode.com/beta#
  2. Create a project and switch to JavaScript editor
  3. Click "Open in VS Code" under simulator
  4. Access the MakeCode Asset Explorer by clicking on the MakeCode icon in the Visual Studio Code action bar
  5. Create a new tile asset

Actual behavior No delete button for Tiles

Expect behavior Add delete button for Tiles

Screenshot image

Additional context 1.OS: Windows11 2.arcade version: 1.13.9 3.Microsoft MakeCode version: 8.6.11

jwunderl commented 1 year ago

Adding it would just be adding an '|| view == tileExplorer' here, but it would have been intentionally not included because it would break the tilemaps that reference those tiles -- I don't think we do any modification of the .data of assets at all outside the iframe currently and doing so properly would probably be a decent chunk of work (@riknoll to double check?)

I guess another workaround would be to still handle it all in asset frame, and make it so you could set an entry in TileMap.tileset to null and it'd get replaced with transparency next load / on compile or something... but that'd feel real bad to me and feels like something that could result in subtle data loss eventually

image
riknoll commented 1 year ago

yes, i intentionally didn't include it because tiles are annoying to delete.