microsoft / vscode-makefile-tools

MAKE integration in Visual Studio Code
Other
185 stars 55 forks source link

debug.internalConsoleOptions not honored by makefile.outline.launchDebug #374

Open FrostKiwi opened 1 year ago

FrostKiwi commented 1 year ago

https://github.com/microsoft/vscode/issues/160265 was closed for being extension related, so reporting it here instead. Though I'm not sure, if the culprit is here or https://github.com/microsoft/vscode-cpptools/

Using GDB as the debugger, compiling via the extension Makefile tools with GCC as the compiler, as provided by MSYS2+MinGW64 on Windows 10.

Debugging is provided by the command makefile.outline.launchDebug

Every time I start debugging, it switches to the debug console. This is fairly annoying, since I want to see the actual console with its outputs and local variables in the side bar. The debug console taking priority and stealing focus from the output terminal is a small bump each time I debug.

Screenshot ![image](https://user-images.githubusercontent.com/60887273/188826781-fed0d80a-8fef-41c6-ab1b-a77bc76fc692.png)

According to https://github.com/Microsoft/vscode/issues/11372 you are supposed to set "debug.internalConsoleOptions": "neverOpen", but that setting is not honored. I have set this in launch.json, settings.json and in the GUI. It is simply ignored in the case of the GDB debug console.

Does this issue occur when all extensions are disabled?: Yes

Version Info ``` Version: 1.71.0 (user setup) Commit: 784b0177c56c607789f9638da7b6bf3230d47a8c Date: 2022-09-01T07:36:10.600Z Electron: 19.0.12 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0.19044 Sandboxed: No ```

Steps to Reproduce:

  1. Set "debug.internalConsoleOptions": "neverOpen"
  2. Launch with GDB as the debugger
bobbrow commented 1 year ago

I disagree with the VS Code team's assessment of ownership for this issue and commented on the issue you opened in the vscode repo. I don't see how we could control this behavior with the API's we currently have. Let's see what they say.

andreeis commented 8 months ago

@bobbrow , are you able to comment on https://github.com/microsoft/vscode/issues/160265? I see the conversation blocked only to the initial contributors. I wanted to send a ping to see what I do with this bug. If you can't I'll create a new issue.

gcampbell-msft commented 2 months ago

Created a new vscode issue here: https://github.com/microsoft/vscode/issues/211266

gcampbell-msft commented 2 months ago

@FrostKiwi Could you test again on the most recent version of vscode and this extension to see if this is still reproducing?