search

microsoft / vscode-makefile-tools

MAKE integration in Visual Studio Code
Other
194 stars 58 forks source link

don't cache when empty, don't configure when fullFeatureSet is false #455

Closed gcampbell-msft closed 1 year ago

gcampbell-msft commented 1 year ago

We realized that on startup, even when we didn't find makefiles, or didn't find things that set fullFeatureSet to true, we still were registering with cpptools and calling notifyReady. This caused us to take over control of intellisense with cpptools which caused a broken experience. I believe this fixes this because it first checks that fullFeatureSet is true. Additionally, it still lets manual configures to happen (from the command pallette).

Additionally, we check for an empty configuration before we cache. If it's empty, we don't cache.

andreeis commented 1 year ago

Looks good, fix for https://github.com/microsoft/vscode-makefile-tools/issues/449.