search

microsoft / vscode-makefile-tools

MAKE integration in Visual Studio Code
Other
184 stars 55 forks source link

Implement a post configure script (sibling to pre-configure script) #484

Closed gcampbell-msft closed 11 months ago

gcampbell-msft commented 12 months ago

This PR includes an update that adds support for a post-configure script.

Additionally, it includes a slight refactor that allows for better sharing of the pre/post-configure script commands.

andreeis commented 11 months ago

I tested this and works well. So just my 2 comments, the % one being important. I see the test failures, expected baseline updates caused by one more setting we added. Not sure if we do any testing about preconfigure, probably nice to add something, some other time also good.

gcampbell-msft commented 11 months ago

I tested this and works well. So just my 2 comments, the % one being important. I see the test failures, expected baseline updates caused by one more setting we added. Not sure if we do any testing about preconfigure, probably nice to add something, some other time also good.

Do you see any locations that would cause failures in test other than the expected not printing post-configure setting? It seems that there is also some additional output that wasn't there before.