microsoft / vscode-makefile-tools

MAKE integration in Visual Studio Code
Other
184 stars 55 forks source link

quotation escape bug #497

Closed HillalRoy closed 10 months ago

HillalRoy commented 10 months ago

It's compiling but vscode showing error unrecognized token

CFLAGS = -DA_LOG_DOMAIN=\"myapp\" 
unrecognized token C/C++(7)
---
#define a_debug(__VA_ARGS__...) a_log (A_LOG_DOMAIN, A_LOG_LEVEL_DEBUG, __VA_ARGS__)
Expands to:

a_log (\"myapp\", A_LOG_LEVEL_DEBUG, ...)
zhykzhykzhyk commented 10 months ago

already described in #465

my workaround was -D 'VAR="str"'

gcampbell-msft commented 10 months ago

@zhykzhykzhyk Thanks for describing the fix! Closing this issue thanks to the resolution.

zhykzhykzhyk commented 10 months ago

@zhykzhykzhyk Thanks for describing the fix! Closing this issue thanks to the resolution.

I think a real fix is needed, as changing all existing makefiles to the only format that this extension can handle isn't a great idea

gcampbell-msft commented 10 months ago

@zhykzhykzhyk This is good feedback, we'll track this in #465. Please upvote that issue and maybe even follow up again on that issue so that we can make sure to prioritize it correctly. Thanks!

HillalRoy commented 10 months ago

Every time Makefile is generated I have to modify the Makefile it's very annoying