Warning about possible commands being run in --dry-run is misleading and confusing

gcampbell-msft commented 4 months ago

          This error message is _very_ confusing. I had no clue what I was being asked and the first many times understood it to say _Hey, VS Code is configuring this project, but you can still run code using `--dry-run` if you wish_

Is it actually Configuring project? That's a progressive verb, leading readers to believe something is happening in the background. My guess is it means it is in some configuration flow and needs input
Why is --dry-run relevant at all? This is unexplained, and there are no buttons for more information. Is VS Code going to run things in --dry-run without me asking? Or is this just informing me of a side-effect possible in make, a tool my project is, definitionally, already using?
- If the former (VS Code is warning me it will automatically run make with --dry-run for some reason and I need to confirm my Makefile has no side effects, then ask that
My present interpretation, after finding this ticket, is it's literally just telling me about make behavior? It should probably read something like "It is possible for make to have side-effects even when --dry-run is provided. Enable Makefile extension for this project?"

Originally posted by @jasonmp85 in https://github.com/microsoft/vscode-makefile-tools/issues/506#issuecomment-1947191752

gcampbell-msft commented 4 months ago

@jasonmp85 ended up finding the answer to his questions: https://github.com/microsoft/vscode-makefile-tools/issues/506#issuecomment-1947218152, but the possible issue still stands about the pop-up being misleading.

MightyCreak commented 3 months ago

I was confused as well, especially because I didn't know that make had a --dry-run command-line option.

gcampbell-msft commented 3 months ago

@MightyCreak Thank you for the feedback, we are currently working on a PR #573 that removes the dry-run pop-up. Thanks!

gcampbell-msft commented 3 months ago

@MightyCreak We have merged #573 and it should be available in pre-release within the hour.

MightyCreak commented 3 months ago

Thanks! And thank you for the heads up!

jasonmp85 commented 3 months ago

Thanks for the resolution! Reporting this felt minor, but I'm glad to see the attention to user-experience here!

Yingzi1234 commented 2 months ago

Happy to see your issue has been resolved, thanks for contributing to Developer Community.

microsoft / vscode-makefile-tools

Warning about possible commands being run in --dry-run is misleading and confusing #562