The preview version does not appear to be working properly

microsoft / vscode-makefile-tools

MAKE integration in Visual Studio Code

Other

194 stars 58 forks source link

The preview version does not appear to be working properly #590

Closed SeasClouds closed 2 months ago

SeasClouds commented 5 months ago

I updated to the preview version (v0.10.5) and it is not working properly. didn't handle dry-run output, and didn't communicate with the cpp extension. Normal after running Makefile: Clean Configure

gcampbell-msft commented 5 months ago

@SeasClouds Am I understanding you correctly that running Makefile: Clean Configure fixes the issue? If not, I'm not sure what you mean by "Normal after running Makefile: Clean Configure"

SeasClouds commented 5 months ago

@gcampbell-msft Running Makefile: Clean Configure can fix this issue, but every time vscode is opened, it is necessary to run Makefile: Clean Configure

gcampbell-msft commented 5 months ago

@SeasCloud What is your makefile.configureOnOpen setting set to? Could you set it to true and see if this issue goes away?

SeasClouds commented 5 months ago

@gcampbell-msft Setting it to truestill raises the issue. This issue should be caused by #573 submission. When extension.getFullFeatureSet() and configuration.getConfigOnOpen() return true, make.cleanConfigure(make.TriggeredBy.cleanConfigOnOpen) will not run. Is this your expectation

gcampbell-msft commented 5 months ago

@SeasClouds Ah, great catch, I'll fix this