[Loc] pre-config and post config failed info not localized both in output and pop up dialog

microsoft / vscode-makefile-tools

MAKE integration in Visual Studio Code

Other

195 stars 60 forks source link

[Loc] pre-config and post config failed info not localized both in output and pop up dialog #611

Closed PhoebeTf closed 4 months ago

PhoebeTf commented 4 months ago

Environment: VSCode 1.90.1 + Makefile Tools v0.10.9(pre-release)

More info: Repro Language: All 13 loc languages Repro platform: Windows, Linux, Mac

Repro steps:

Open VScode and change the display language to CHS
Clone the makefile project (such as: https://github.com/remonbonbon/makefile-example) and open it in VSCode
Click F1 to open command palette and input “Makefile: Pre-configure” or “Makefile: Pre-configure”, check the output log and pop up info localization status

Expected result: Pre-config and Post-config failed info localized both in output and pop up dialog

Actual result: Pre-config and Post-config failed info not localized both in output and pop up dialog

Pre-config:

Post-config:

gcampbell-msft commented 4 months ago

Fixed in #615

PhoebeTf commented 4 months ago

@gcampbell-msft Verified with Makefile Tools v0.10.12, Pre-config and Post-config failed info has been localized in the pop up dialog, while still not localized for output info. Could you help to confirm do I need reactive this issue? Or just track the issue 610 and verify the output info status after that issue fixed?

gcampbell-msft commented 4 months ago

This is expected, as I'm solving the localization of the output panel in a different PR #610

PhoebeTf commented 4 months ago

Got it and will verify the output info status again after issue https://github.com/microsoft/vscode-makefile-tools/issues/610 fixed.

PhoebeTf commented 3 months ago

@gcampbell-msft Verified with Makefile Tools v0.10.21(pre-release), the output info for pre and post config has been localized, while the output info for post-config have been changed as same with pop up dialog info, is this expected? Do I need create a new issue to track it? CHS:

ENU:

gcampbell-msft commented 3 months ago

@PhoebeTf Sorry, I'm not fully understanding. What is the issue? What happened before versus now?

PhoebeTf commented 3 months ago

@gcampbell-msft Sorry for confused you, the new issue is output info for post-config have been changed from "No post-configure script is set in settings. Make sure a post-configuration script path is defined with makefile.postConfigureScript." to "Post-configure failed: no script provided.", which is same with pop up dialog info, is this expected?

Detailed screenshot as below: MakefileTools V0.9.10: "No post-configure script is set in settings. Make sure a post-configuration script path is defined with makefile.postConfigureScript."

MakefileTools V0.10.21(pre-release): "Post-configure failed: no script provided."

gcampbell-msft commented 3 months ago

@PhoebeTf Thanks for checking, I have a PR for this here: #632

Yingzi1234 commented 3 months ago

@gcampbell-msft @PhoebeTf This issue has been fixed on latest Makefile tools version v0.11.4(pre-release), you can get the details below. Thank you!

@gcampbell-msft Sorry for confused you, the new issue is output info for post-config have been changed from "No post-configure script is set in settings. Make sure a post-configuration script path is defined with makefile.postConfigureScript." to "Post-configure failed: no script provided.", which is same with pop up dialog info, is this expected?

Detailed screenshot as below: MakefileTools V0.9.10: "No post-configure script is set in settings. Make sure a post-configuration script path is defined with makefile.postConfigureScript."

MakefileTools V0.10.21(pre-release): "Post-configure failed: no script provided."