microsoft / vscode-makefile-tools

MAKE integration in Visual Studio Code
Other
196 stars 60 forks source link

[Local] String “The pre-configure succeeded” and “The post-configure succeeded” not localized in Makefile tools output window #636

Closed Yingzi1234 closed 1 month ago

Yingzi1234 commented 3 months ago

More info: 1. This issue is reproduced on v0.9.10(release), so it is not a regression issue

  1. Repro Language: all loc
  2. Repro platform: Windows, Linux, Mac

Repro steps:

  1. Open VScode and change the display language to CHS
  2. Open VSCode and clone the repository, such as: https://github.com/remonbonbon/makefile-example.git
  3. Create a pre-configure file or post-configure, such as: “preConfigureScript.bat”
  4. Copy the contents: ECHO “PRECONFIGURE” %~1 to this file
  5. Copy this file's path to the "Makefile: Pre Configrue Script” settings
  6. Click F1 to run command "Makefile: Pre-configure"
  7. Check the output window

Expected result: Makefile output log all localized

Actual result: String “The pre-configure succeeded” and “The post-configure succeeded” not localized in Makefile tools output window

pre-configure: image

post-configure: image

gcampbell-msft commented 3 months ago

Fixed by #634

Yingzi1234 commented 2 months ago

@gcampbell-msft I apologize that this issue has not been fully resolved, so I've turned it back on. Only “The pre-conigure succeeded” is translated, but “The post-configure succeded” has not been translated yet. You can get the details below. Thank you!

ENV: Makefile tools verison: v0.11.6(pre-release) vscode verison: 1.92.2

Post-configure image

Pre-configure image

Yingzi1234 commented 2 months ago

@gcampbell-msft I'm sorry to say that this issue still hasn't been resolved by this PR 643 , so I've turned it back on. “Post-configuration success” has not been translated yet. You can get the details below. Thanks! image

gcampbell-msft commented 1 month ago

Just tested in pre-release, this is fixed in the most recent version 👍

Yingzi1234 commented 1 month ago

@gcampbell-msft Thank you very much for reconfirming, this issue has been fixed on latest Makefile Tools version 0.12.4(pre-release), you can get the details below. Thank you! Image