Closed xiahualiu closed 3 months ago
@xiahualiu This is definitely an issue, however, there were not many significant changes made in 0.10 (see CHANGELOG here), and in our release testing we didn't see issues like the one you describe. All that simply to say, nothing immediately comes to mind of what could be going on.
To help us diagnose more, could you give us a couple of answers and try some other versions out?
@xiahualiu Also, in addition to the above information, if you could provide a sample project for us to try to reproduce with, that would be exceedingly helpful as well. Thanks for your patience and understanding.
Thank you, sure no problem. I have tested that v0.10.1 is the last good version on my WSL. It stops working on v0.10.2 and later versions. I will create a demo project and see if I can reproduce it there.
@xiahualiu What happens if you explicitly run the "Makefile: Configure" command?
@xiahualiu Forgot to mention, when you project a demo project, it is necessary to also provide specific details about what OS you're on, and how to replicate your setup. Thanks
I may have an inkling of the changes between that 0.10.1 and 0.10.2. What do you see as the setting for makefile.configureOnOpen
when you open your project?
Also, do you see this pop-up in the bottom right corner?
This bug can be reproduced easily with the following demo project:
$ tree
.
├── Makefile
└── hello.c
0 directories, 2 files
$ cat hello.c
#include <stdio.h>
int main() {
printf("Hello World!\n");
}
$ cat Makefile
hello: hello.c
/usr/bin/gcc hello.c -o hello
And it will make the Makefile Tool stuck forever.
Our project also uses absolute paths for compilers because there are multiple cross compilers used in our project.
@xiahualiu And to confirm you said that you were opening this in WSL?
@xiahualiu And to confirm you said that you were opening this in WSL?
Yes, WSL, default Ubuntu OS.
~If I change /usr/bin/gcc
to gcc
, then there is no problem at all, I suspect there is something wrong with the string handling code.~
No even after I rename it to gcc
it still wouldn't work for some reason.
I have found the issue, and I think that it's by design, I've reproed with your project and the reason that it's happening is that you need to answer the pop-up question about whether you want to configure using Makefile:
Once you answer "Yes" to this question it configures and everything behaves as expected.
Could you confirm that this resolves your issue?
This pop-up question windows doesn't appear if I switch back to v0.9.10 and upgrade to v0.10.25.
@xiahualiu While I believe that the above may resolve your issue, there is definitely a bug, and I believe I have a fix, could you manually install this vsix?
You'll first need to modify the extension to be .vsix instead of .zip. Thanks! makefile-tools.zip
This zip file you uploaded worked for me. Thanks! Although I am still not seeing the pop up windows, but it worked just as v0.9.10.
@xiahualiu The way to confirm my suspicion would be to navigate to makefile.configureOnOpen
and click the gear icon and "reset" the setting. Then, when you reload, you should see the popup.
You are correct, after toggling makefile.configureOnOpen
to true
and reload the window the Makefile Tool v0.10.25 just works as intended.
Perfect, thanks for your quick responses and testing, I plan to get a PR merged as soon as I can to get a fix into the pre-release and then perform an official release as well with the fix.
@xiahualiu The most recent pre-release contains the fix, could you test again on that? It'd be most helpful if you tested installing fresh and the update scenario with different values for "configureOnOpen". I very much appreciate your help.
I can confirm pre-release v0.11.1 works fine for me.
@gcampbell-msft We can reproduced this issue on makefile version v0.10.25(preview), you can get the details below. Thank you!
Repro steps:
Actual result: Configuration Failed
Output info: https://microsoft-my.sharepoint.com/:t:/p/v-cathyzhang/EfQysn_VKO5NqD65Reckp7oBEWg6X1d5j8byazFgYr2CoA?e=SibJiy
@gcampbell-msft This issue has been fixed on latest Makfile version v0.11.2(pre-release), you can get the details below. Thank you!
Fixed in pre-release, closing.
It doesn't work anymore.
The Makefile Tools got stuck and it doesn't do anything nor print anything after the configuration is done (or not done, there is no
compile_commands.json
generated at all):Output console:
Extension Host (Not changed before and after v0.10.25):
After that the extension is like this and VS Code showed activating extension all the time:
Please note this only happened after I upgraded it to v0.10.25, v0.9.10 didn't have any issue. I was using this tool on WSL:Ubuntu and Intellisense was disabled (I use clangd).