search

microsoft / vscode-makefile-tools

MAKE integration in Visual Studio Code
Other
196 stars 60 forks source link

Parse out the line continuation character at the end of lines #659

Closed gcampbell-msft closed 2 weeks ago

gcampbell-msft commented 1 month ago

Fixes #628

Fixes the parsing of the line continuation character.

gcampbell-msft commented 1 month ago

Notating here that there may be more work to do to make the regex smarter, for example, we may want to only do this if it's a standalone "\", if it's "\" at the end of a line, we may not want to do this

gcampbell-msft commented 1 month ago

TODO: This comment indicates that this doesn't yet fix the issue: https://github.com/microsoft/vscode-makefile-tools/issues/628#issuecomment-2407783475

gcampbell-msft commented 4 weeks ago

@moyo1997 Ping for review, thanks!