microsoft / vscode-makefile-tools

MAKE integration in Visual Studio Code
Other
195 stars 60 forks source link

Launch Configuration shell customisation #664

Open Mebius973 opened 1 month ago

Mebius973 commented 1 month ago

On windows, the shell set with

    "terminal.integrated.profiles.windows": {
        "MSYS2 UCRT64": {
            "path": ["C:\\devkitPro\\msys2\\usr\\bin\\zsh.exe"],
            "env": {
                "MSYSTEM": "MINGW64",
                "CHERE_INVOKING": "1",
                "MSYS2_PATH_TYPE": "inherit"
            },
            "overrideName": true
        }
    },

is not taken into account and there is no way to customize it. It defaults to cmd:

  if (process.platform === "win32") {
            terminalOptions.shellPath = "C:\\Windows\\System32\\cmd.exe";
        }

It would be nice to, at least, by able to customize that (if needed of course, it's nice to havec a default behaviour too)

Yingzi1234 commented 1 month ago

@gcampbell-msft The user's issue seems to be about configuring the integrated terminal in Visual Studio Code. In their configuration they tried to set the terminal to use MSYS2 UCRT64, but it always falls back to the default cmd.exe. I don't think this problem should be part of the Makefile. Could you help to put it back inside the correct path? Thank you in advance!

Mebius973 commented 1 month ago

The terminal itself is properly set: Image

I'm having problems with one the extension launches: Image

Although, on a second test and despite the "Microsoft" stuff, it seems to react to shell functions so I guess it's just weirdly started which I don't know how to fix.

gcampbell-msft commented 1 month ago

@Mebius973 Could you please provide some context on what version of the extension you're seeing this on, and also provide a sample repro?

Thanks!