search

microsoft / vscode-markdown-tm-grammar

VS Code built-in markdown extension's Textmate grammar
MIT License
64 stars 49 forks source link

🐛 Fix single tilde (`~`) strikethrough parsing #107

Closed babakks closed 2 years ago

babakks commented 2 years ago

This PR fixes microsoft/vscode#146610

babakks commented 2 years ago

@mjbvz Just one thing. I had some problems running the tests since the actual data contained an extra hc_light which was missing in the expected results. Now, I'm wondering if we would better change the assertion method hasThemeChange(d, p) to look for the keys of p within d (instead of doing it the other way).

What's your opinion?

babakks commented 2 years ago

@mjbvz I don't have access to see the details of the failed checks. Could you please check them?

mjbvz commented 2 years ago

Thanks! The test failures look expected. They were caused by our addition of a light high contrast theme. I'll update them shortly

babakks commented 2 years ago

@mjbvz If you want, I can make the changes to include HC light in the expected results.