microsoft / vscode-markdown-tm-grammar

VS Code built-in markdown extension's Textmate grammar
MIT License
64 stars 49 forks source link

Links enclosed in < > not linked or rendered correctly #66

Closed nigelsim closed 2 years ago

nigelsim commented 4 years ago

The following Markdown should produce a link that automatically escapes the space in the link.

[link text](</file im linking to.md>)

However, it is not possible to follow this link in the editor, and the colourising is incorrect.

Screenshot from 2019-12-22 15-43-28

This does however link correctly in the VS Code Markdown Preview.

preview-link

This definition has changed in 0.29. The relevant Common Mark testcase is as follows:

  {
    "markdown": "[link](</my uri>)\n",
    "html": "<p><a href=\"/my%20uri\">link</a></p>\n",
    "example": 486,
    "start_line": 7543,
    "end_line": 7547,
    "section": "Links"
  },
mjbvz commented 4 years ago

This extension only handles the grammar highlighting, not the link providing logic (but as you note the highlighting is also incorrect)

Please file the link detection issue against VS Code itself

rahul0705 commented 4 years ago

This looks like a duplicate of #80 which provides additional detail?

mjbvz commented 2 years ago

Fixed by 2f9bda284d391f97982f7932ba49eb89b2ac83b1