microsoft / vscode-maven

VSCode extension "Maven for Java"
https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-maven
Other
179 stars 88 forks source link

Command-breaking quote usage #1011

Closed Pixel48 closed 7 months ago

Pixel48 commented 8 months ago

Describe the bug Extension wraps build command in double quotes, but it also wraps path to custom mvn fine in double quotes, which breaks overall quote structure and renders any command it produces unusable. Problem is present even with default setting purely because of bad quote usage - reusing command in cmd without wrapping in quotes makes it usable image

This ss is made on default vscode-maven settings, so it means that even on defaults this extension is unusable just because of quotes

To Reproduce Steps to reproduce the behavior:

  1. Download apache-maven into C:/.../Java/ directory image
  2. Set maven from point 1 in maven.executable.path image
  3. Try to create JavaFX project image
  4. Watch how wrapping command in double quotes makes it unexecutable image
  5. Bonus points if you try to execute command from inside the quotes, to make it work just fine... image

Expected behavior Building project without making itself unusable by creating doube double-quotes

Environments (please complete the following information as much as possible):

testforstephen commented 8 months ago

I tried it in Windows 11, it works for me with double quotes. image