search

microsoft / vscode-maven

VSCode extension "Maven for Java"
https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-maven
Other
182 stars 88 forks source link

Notification of breaking api change with v1.92 release of VS Code #1035

Closed deepak1556 closed 2 months ago

deepak1556 commented 2 months ago

Hello from the VS Code team 👋

In our next release v1.92, we will update to Electron 30 which includes Node.js 20.14.0. This Node version contains a breaking change, in response to a CVE, which may affect you if you execute .bat or .cmd files on Windows. Based on a simple scan of your extension's source code, you may be impacted by this change. The stable VS Code that contains this update will be released in early August.

Action: please try out your extension on this month's VS Code Insiders on Windows. If you are affected by this change, you will encounter an EINVAL error when you try to spawn a bat/cmd file.

Node.js has added a section on batch file spawning to their documentation. To fix any issues:

  1. Find locations where you call child_process.spawn to execute a batch file on Windows
  2. Add shell: true or shell: process.platform === 'win32' to the options object
  3. If the batch script path may contain spaces, you will also need to wrap the path in quotation marks.

Please let us know if you run into issues or if you need clarification.

Happy coding!

testforstephen commented 2 months ago

thanks for reaching out. We have enabled shell: true when using child_process.spawn, they're not affected by this breaking change.

https://github.com/microsoft/vscode-maven/blob/6a90eac5fa0e0374f83742471ef0efe22b3a9979/src/utils/mavenUtils.ts#L88-L91