installation through the java extension pack cannot find/run mvn.cmd

microsoft / vscode-maven

VSCode extension "Maven for Java"

https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-maven

Other

183 stars 89 forks source link

installation through the java extension pack cannot find/run mvn.cmd #544

Open OlafEichstaedt opened 3 years ago

OlafEichstaedt commented 3 years ago

Describe the bug After installation through the java extension pack, building a new project from a archetype would work, but right click "install" in the "Maven" part of the explorer pane would not find the mvn command.

Typing mvn in an integrated or separately opened terminal would not work: "mvn is not recognized as an internal or external command, operable program or batch file."

After installing Maven manually (download zip-archive from maven.apache.org/download.cgi, unzip, add the /bin folder to %PATH% mvn executes fine and right click "install" in the "Maven" part of the explorer pane starts the build process.

Expected behavior I would have expected the package to make mvn available after install (e.g. by placing its folder in the %PATH% or by setting the executables location. Alternative: issue clear instructions what needs to be done manually to locate the executable.

Environments (please complete the following information as much as possible):

OS: Windows 10, 10.0.18362 Build 18362
VS Code version: 1.50.1
Extension pack version: 0.10.0
- Maven extension version: 0.25.0

(If you would like me to provide more information or run some specific tests, please let me know.)

Eskibear commented 3 years ago

Before " installing Maven manually ", if you don't have a mvnw.cmd on the project root, or any mvn/mvn.cmd on your %PATH%, then the behavior is as expected.

I agree that to improve the first-time experience, we should either download a maven distribution for users, or provide better instructions. Below are some obstacles:

Update %PATH% on the fly. 1) updating environment varibles may require elevated privileges. 2) Integrated terminals are spawned from vscode process, whose %PATH% is out-of-date even if we manage to install a maven distro and update %PATH%. In the terminal, it still cannot find the mvn.

Alternative: issue clear instructions what needs to be done manually to locate the executable.

Agree. We've investigated and currently the behavior is: the extension searches for mvn as possible as it can (mvnw on project forlder, mvn on %PATH%), and pops up a message box for users to manually specify the path if nothing found.

gitfourteen commented 3 years ago

After installing java extension pack which includes Maven, and then we need reinstall Maven manually? Is this java world?

Eskibear commented 3 years ago

then we need reinstall Maven manually?

No you don't have to reinstall Maven if you already have one configured in your PATH.

Is this java world?

So please introduce your java world, thanks.

HolgerSin commented 2 years ago

I'm very new to Maven and was also confused by this. Took me a long time to figure out I needed to download the maven zip file and adjust the PATH variable (actually, I'm not even sure right now if that is really necessary - does the VSCode Maven extension contain a Maven package?) To be fair, it does say under Requirements "Maven / Maven Wrapper". Anyway, wasn't clear enough for me...