microsoft / vscode-maven

VSCode extension "Maven for Java"
https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-maven
Other
179 stars 88 forks source link

would better detect mvn installed by SDKMAN #765

Open Eskibear opened 2 years ago

Eskibear commented 2 years ago

Currently we only check PATH for mvn if it's not specified.

SDKMAN is a popular tool to install/manage maven distributions, and default location is: /usr/local/sdkman/candidates/maven/current/bin/mvn

jiahut commented 2 years ago
{
    "maven.terminal.customEnv": [
        {
            "environmentVariable": "JAVA_HOME",
            "value": "/usr/local/sdkman/candidates/java/8.0.302-open"
        }
       ]
}

Even if the JAVA_HOME variable is explicitly specified as above, it does not work well with SDKMAN, the JAVA_HOME variable is always equal to /usr/local/sdkman/candidates/java/current in the maven terminal

Eskibear commented 2 years ago

Are you using zsh or bash? I've heard such issue in zsh before, because JAVA_HOME was always overidden by what's defined in .zshrc.

jiahut commented 2 years ago

@Eskibear

echo $SHELL

/bin/bash