search

microsoft / vscode-mono-debug

A simple VS Code debug adapter for mono
Other
159 stars 173 forks source link

Remove dependency to SDB #15

Closed t-h-e closed 7 years ago

t-h-e commented 7 years ago

Neccessary packages have been added to packages.config Some code from SDB is reused and was added to src/sdb Removed SDB from project

weinand commented 7 years ago

@t-h-e Hi! Sorry for the late response...

What is the purpose/benefit of removing the dependency on SDB?

weinand commented 7 years ago

@t-h-e thanks for the PR! On top of that I've removed lots of dead wood.

t-h-e commented 7 years ago

I should have linked the following issue: https://github.com/Microsoft/vscode-mono-debug/issues/12

weinand commented 7 years ago

@t-h-e oh, I see. I forgot about #12. Could you try mono-debug on Windows and verify that it works for? Then we could close #12.

t-h-e commented 7 years ago

works for me :)

weinand commented 7 years ago

great!