search

microsoft / vscode-mono-debug

A simple VS Code debug adapter for mono
Other
159 stars 173 forks source link

Changes for Unity debug extension #3

Closed lukaszunity closed 8 years ago

lukaszunity commented 8 years ago

Some changes required for Unity debug extension: https://github.com/Unity-Technologies/vscode-unity-debug

weinand commented 8 years ago

@lukaszunity Thanks a lot for your pull request! And I see already more great commits... But To enable us to quickly review and accept your pull requests, may I ask you to always create one pull request per issue (please see https://github.com/Microsoft/vscode/wiki/How-to-Contribute).

My problem with your pull request is, that the first two commits open mono-debug for subclassing. The first commit is not a problem, but I'm a bit reluctant with the second (ignore variables). I looked into your vscode-unity-debug and got the impression, that your changes for unity support are small. What do you think about the idea of folding the Unity support directly into mono-debug?

lukaszunity commented 8 years ago

@weinand Alright, I will create a PR pr issue.

Regarding subclassing; I was trying to reuse as much functionality from mono-debug as possible. But I think the best way forward for the unity-debug extension is just to duplicate the code in MonoDebugSession.cs into UnityDebugSession.cs and have all the necessary Unity changes live in our repo.

I don't think it makes sense to combine mono-debug and unity-debug. A lot more Unity specific code will be included in future and we want to be able to control the release schedule for the unity-debug extension.