microsoft / vscode-mono-debug

A simple VS Code debug adapter for mono
Other
159 stars 173 forks source link

Replace debuger-libs binaries by source code #36

Closed VysotskiVadim closed 3 years ago

VysotskiVadim commented 7 years ago

It's few reasons to replace debugger-libs binaries by source code:

  1. debugger-libs classes like SoftDebuggerSession always fail silently, i.e. it just won't work without any exception and logs, so it really hard to understand what is wrong without debugging source code of debuger-libs.
  2. debugger-libs isn't well documented, it doesn't have some kind of tutorials, so I believe that reading source code is the best way to understand how it works.
  3. Owner of Mono.Debugger.Soft, Mono.Debugging and Mono.Debugging.Soft packages is Jetbrains: the release process isn't documented at all (at least I hasn't found any info about it).
weinand commented 7 years ago

@VysotskiVadim why do you think that the owner of Mono.Debugger.Soft, Mono.Debugging and Mono.Debugging.Soft packages is Jetbrains?

VysotskiVadim commented 7 years ago

nuget gallery mono debugger soft 1 0 20170212 42 2017-06-15 16-35-07

VysotskiVadim commented 7 years ago

Please, see pull request https://github.com/Microsoft/vscode-mono-debug/pull/37

borgdylan commented 7 years ago

I had raised this issue in the past. The maintainers of the actual source code should have been consulted by Jetbrains before their code was packaged and published under an owner that is not them. Also, there is no indication of whether Jetbrains applied any patches on the vanilla source code.

akoeplinger commented 3 years ago

debugger-libs was replaced with sources from a git submodule with https://github.com/microsoft/vscode-mono-debug/pull/64.