microsoft / vscode-mssql

Visual Studio Code SQL Server extension.
Other
1.53k stars 457 forks source link

A11y_mssql for VSCode_Message Window_Keyboard:After pressing tab key(Ctrl+M) from "More actions" keyboard focus is going to bottom status bar instead of going to the "messages" dropdown. #17192

Closed Roopesh-T closed 1 year ago

Roopesh-T commented 2 years ago

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags:#A11yMAS;#A11yTCS;#BM_mssql for VSCode_Jan2022;#mssql for VSCode;#Win32;#FTP;#DesktopApp;#A11ySev2;#Keyboard;#AINotInScope;#FocusOrder;#WCAG2.4.3;#Regressed:03-02-2023;

Environment Details:

Application Name: mssql for VSCode Windows Version: Win11

Repro Steps:

  1. Open Visual studio code
  2. Tab till extension button and search for "mssql"
  3. Tab till install and move to the SQL Server button
  4. Tab till Add Connection Button and insert the valid credentials
  5. Right click on the server/database node you want to run the new query on.
  6. Press enter “New Query” write any valid query and click on "Execute query button"
  7. Message Window will open and check if the focus order is correct in message window.

Actual:

After pressing tab key(Ctrl+M) from "More actions" keyboard focus is going to bottom status bar instead of going to the "messages" dropdown.

Similar issue is also observed in Select top 1000 Results window_focus order is coming from bottom to top.

Expected:

After pressing tab key(Ctrl+M) from "More actions" keyboard focus should go to "messages" dropdown bottom instead of going to the status bar.

User Impact:

Keyboard users will face difficulty in navigating the Message Window

Attachments

17192_A11y_mssql for VSCode_Message Window_Keyboard

smartguest commented 2 years ago

This issue appears to be caused either by the way dividers are arranged in the extension or how vscode handles elements in windows. This may be fixed by changing the way elements are arranged in vscode-mssql (need to know how vscode determines what element to tab next, or maybe this might just be default vscode behavior)

smartguest commented 2 years ago

Closing as this is standard vscode behavior with webview based windows. This is demonstrated as when you open an IPYNB notebook in vscode, the same tab behavior is seen there as well.

Roopesh-T commented 1 year ago

The issue is still repro in the latest env 216575569-acdc8f4a-0d0c-4911-8672-31a37b6a4167 please reopen the bug. 17192_repro

alanrenmsft commented 1 year ago

@Roopesh-T this is a dupe of https://github.com/microsoft/vscode/issues/166768, please close.

Roopesh-T commented 1 year ago

Closing the bug, as the bug https://github.com/microsoft/vscode/issues/166768 is the exact same issue. and the team is following up on that bug. Git Hub Tag: #closed;