Open Roopesh-T opened 2 years ago
Investigation for this issue shows that it's a dependency issue related with tree items for vscode, this means the functionality for hover and highlight over a tree item from vscode is an issue that is not specifically limited to vscode-mssql, I'll forward this issue to the vscode team to handle.
This is an upstream vscode issue that is being investigated by vscode-mssql, it is currently under discussion, this may not be changed in a future release as mentioned here: https://github.com/Microsoft/vscode/issues/52016#issuecomment-641096443
As one of the external bugs is open https://github.com/microsoft/vscode/issues/132344 Please Open this bug and do not close this bug. Only a C & AI tester should close this bug.
@Roopesh-T what is your Microsoft alias? Let's have a chat about the process.
@alanrenmsft Here is my alias v-roopesht@microsoft.com
From the user perspective we already read the aria label of the element once the user navigates on it. Aria label is usually the same as what is hovered or better, so this issue is covered for blind users. The only users this makes sense for imho are users who can not use the mouse and are not using a screen reader. Thus they navigate using the keyboard to an action and they would like to know more details about that action. So it would be nice to have an explicit command to trigger this native hover for those users. However web browsers do not support this as far as I know and it is not possible to trigger a native hover.
We can maybe look into this once MS Teams starts supporting this. The only solution I see is to build a custom hover which I would not do for a feature which none of the users requested.
@alanrenmsft As per the above comment from last 2 points could you please let us know which point we can take to consideration.
What is the content of the tooltip? Is it essential to complete the task? would a user be able to complete the task if the tooltips were removed? This information is necessary to determine the true user impact in this case.
The tooltip contains the info of the time and the server on which it got executed and the code itself. If a keyboard user will is not able to access the tooltip from the history he need to navigate to all the different screens to get the info which got executed at which time in which server.
Best use of the tooltip from the history is, it will show the user which code got executed, even thought the editor got closed accidentally.
The user will be able to complete his task even without the tooltip but the tooltip provides the user with a simpler way to work in the application
@Roopesh-T thank you very much for the additional details. We have discussed this internally. Based on the information we have, this functionality can be seen as a preview for the same information that can be access visually, probably even more efficiently, in a different tab. considering that, we recommend downgrading the user impact to severity 3. moving forward, we will talk with the VS Code team to explore ways to minimize the impact of issues like this one for extension developers.
Reducing the Severity of the bug to Sev3 as per C&AI SEM's discussion.
@Roopesh-T This issue is still showing up on our s360 dashboard, could you please see whether you have downgraded it properly?
will reactivate once the issue is properly tagged and won't show up on the dashboard.
It is tagged correctly and now showing up as sev 3 in dashboard, please reopen the bug.
GithubTags:#External;#External:VSCode;
“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:#A11yMAS;#A11yTCS;#BM_mssql for VSCode_Jan2022;#mssql for VSCode;#Win32;#FTP;#DesktopApp;#A11ySev3;#Keyboard;#AINotInScope;#WCAG2.1.1;#Linked:Bug52016;#LinkedBug;#CEACCApproved;
Environment Details:
Application Name: mssql for VSCode Windows Version: Win11
Repro Steps:
Actual:
When using arrow keys to move to data in Query History window, tooltip is not available with the keyboard keys.
Expected:
When using arrow keys to move to data in Query History window, tooltip should available with the keyboard keys which is available with mouse.
User Impact:
Keyboard users will not get the tooltip information.
Attachments