microsoft / vscode-mssql

Visual Studio Code SQL Server extension.
Other
1.55k stars 459 forks source link

A11y_mssql for VSCode_Select top 1000 _ScreenReader:When tabbing to the editor screen reader is not announcing the line number along with the data in the line. #17205

Closed Roopesh-T closed 2 years ago

Roopesh-T commented 2 years ago

Actual:

When tabbing to the editor screen reader is not announcing the line number along with the data in the line.

Similar issue is observed with Jaws

Similar issue is also observed in following screens.

  1. Script as create_editor
  2. Script as Drop_editor
  3. Script as Alter_editor

Expected:

When tabbing to the editor screen reader should announce the line number along with the data in the line like line 1, line 2, line 3....

GitHubTags:#A11yMAS;#A11yTCS;#BM_mssql for VSCode_Jan2022;#mssql for VSCode;#Win32;#FTP;#DesktopApp;#A11ySev1;#AINotInScope;#WCAG1.3.1;#NVDA;#Jaws;#STP;#Element:editor;#Closed;

Environment Details:

Application Name: mssql for VSCode Windows Version: Win11 Jaws version: 2021.2103.174 ILM NVDA Version: Version 2021.3

Repro Steps:

  1. Open Visual studio code
  2. Tab till extension button and search for "mssql"
  3. Tab till install and move to the SQL Server button
  4. Tab till Add Connection Button and insert the valid credentials
  5. After adding the server move to database expand it -->System database expand-->Master expand-->Tables expand -->System table expand and right click on it and select top 1000 option
  6. Select top 1000 window will open
  7. Run NVDA
  8. Tab to the editor Check if the screen reader is announcing the position of the line along with the data in the line.

User Impact:

Screen reader users will not get the position information in which screen reader focus is landing in editor.

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

Attachment

17205 1 17205

smartguest commented 2 years ago

Agreed, the line or row number needs to be announced somehow, this might require changes made to the query table to allow the screen reader to read the table's current row number, or perhaps the table class in general. Somewhere in the table there is some value or a series of values that the screen reader uses.

smartguest commented 2 years ago

The aria rowcount on a slickgrid table is labeled 0 which is incorrect, this needs to be updated to reflect the table more accurately

smartguest commented 2 years ago

Closing as this is mainly an upstream issue related to the grid library and is already closed for exclusion in ADS (for similar issues), issue is non-blocking:

https://github.com/microsoft/azuredatastudio/issues/6662 https://github.com/microsoft/azuredatastudio/issues/6688

smartguest commented 2 years ago

Need to investigate if this happens with vscode in general or just this extension.

smartguest commented 2 years ago

Closing as this is a general vscode issue with the editor and not one limited to the extension

smartguest commented 2 years ago

Relevant issues for the general bug in vscode:

https://github.com/microsoft/vscode/issues/52429

https://github.com/microsoft/monaco-editor/issues/410

Roopesh-T commented 2 years ago

As one of the external bugs is open https://github.com/microsoft/monaco-editor/issues/410 Please Open this bug and do not close this bug. Only a C & AI tester should close this bug.

kburtram commented 2 years ago

@alanrenmsft could you please follow-up what do with this issue?

Roopesh-T commented 2 years ago

@smartguest As one of the external bugs is open https://github.com/microsoft/monaco-editor/issues/410 Please Open this bug and do not close this bug. Only a C & AI tester should close this bug.

alanrenmsft commented 2 years ago

@Roopesh-T could you please follow up with vscode team?

alanrenmsft commented 2 years ago

@Roopesh-T this: https://github.com/microsoft/vscode/issues/52429 is the immediate upstream issue for this issue.

as mentioned in https://github.com/microsoft/vscode/issues/52429#issuecomment-503161037, a workaround has been implemented, can we use it to mitigate the issue?

Roopesh-T commented 2 years ago

closing the bug as the current line info is getting announced using shortcut ctrl+G. Presentation1