microsoft / vscode-mssql

Visual Studio Code SQL Server extension.
Other
1.53k stars 457 forks source link

A11y_mssql for VSCode_Message Window_Keyboard:On pressing tab key from "More actions" keyboard focus is going to bottom status bar instead of going to the "Results" dropdown. #17447

Open prabhudevu opened 2 years ago

prabhudevu commented 2 years ago

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags:#A11yMAS;#A11yTCS;#BM_mssql for VSCode_Sep2022;#mssql for VSCode;#Win32;#DesktopApp;#A11ySev3;#Keyboard;#AINotInScope;#FocusOrder;#WCAG2.4.3;#Win11;#External;#External:VSCODE;#Linked:Bug166768;#CEACCReviewed;

Environment Details:

Application Name: mssql for VSCode Windows Version: Win11 Visual studio code-insiders Version: 1.72.0-insider (user setup)

Repro Steps:

  1. Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility tester after verification of the fix
  2. Open Visual studio code
  3. Tab till extension button and search for "mssql"
  4. Tab till install and move to the SQL Server button
  5. Tab till Add Connection Button and insert the valid credentials
  6. Right click on the server/database node you want to run the new query on.
  7. Press enter “New Query” write any valid query and click on "Execute query button"
  8. Message Window will open and check if the focus order is correct in message window.

Actual:

On pressing tab key from "More actions" keyboard focus is going to bottom status bar instead of going to the "Results" dropdown.

Note:Similar issue is also observed in Select top 1000 Results window_focus order is coming from bottom to top.

Expected:

On pressing tab key from "More actions" keyboard focus should go to "Results" dropdown bottom instead of going to the status bar.

User Impact:

Keyboard users will face difficulty in navigating the Result Window

Attachments

17447_A11y_mssql for VSCode_Message Window_Keyboard

alanrenmsft commented 1 year ago

@prabhudevu this is a VSCode issue, could you please open an issue in vscode repo?: https://github.com/microsoft/vscode

a simple repro is to follow the instructions here and observe that the focus goes to the status bar first before reaching the document content.

https://github.com/microsoft/vscode-webview-ui-toolkit-samples/tree/main/default/hello-world

alanrenmsft commented 1 year ago

upstream issue: https://github.com/microsoft/vscode/issues/166768

fsteffi commented 1 year ago

external bug opened: https://github.com/microsoft/vscode/issues/166768

GithubTags:#LinkedBug;

alanrenmsft commented 1 year ago

@fsteffi @prabhudevu

Regarding https://github.com/microsoft/vscode-mssql/issues/17447, rather than saying it is an external issue, it is more like a duplicate of https://github.com/microsoft/vscode/issues/166768, our product is an extension of VSCode, it lives inside vscode, as soon as it is fixed in VSCode, we get it automatically.

Could you please close the issue https://github.com/microsoft/vscode-mssql/issues/17447 as duplicate?

Thanks Alan

Sent from Outlook

alanrenmsft commented 1 year ago

@prabhudevu @fsteffi , as per this comment, could you please either close this issue or lower the severity?

prabhudevu commented 1 year ago

Lowering the Severity from Sev2 to Sev3.

alanrenmsft commented 10 months ago

@fsteffi @prabhudevu , the upstream issue has been closed as won't fix, could you please close this issue as well?