microsoft / vscode-mssql

Visual Studio Code SQL Server extension.
Other
1.53k stars 456 forks source link

Import correct stylings #18055

Closed cssuh closed 1 week ago

cssuh commented 1 week ago

Fixes cell size alignment (the text is more centered in the after view) and adds correct imported images Also moves some files into reactViews

Before: Screenshot 2024-09-19 at 9 37 50 AM

After: Screenshot 2024-09-19 at 9 36 54 AM

github-actions[bot] commented 1 week ago

VSIX Size Comparison

aasimkhan30 commented 1 week ago

@cssuh What are the icons for?

cssuh commented 1 week ago

@cssuh What are the icons for?

They're for the filtering & sorting plugin and they're currently imported by the table.css file, so that's why I added them.

cssuh commented 1 week ago

Screenshot 2024-09-19 at 9 56 07 AM

This is how they will be used, I just haven't finished the plugin for them yet.

aasimkhan30 commented 1 week ago

@cssuh, I see. Could you move the React resources to the reactviews folder? Currently, the files in the media folder are being copied directly into the VSIX, and the bundle also includes these files, causing duplication of resources.

cssuh commented 1 week ago

@cssuh, I see. Could you move the React resources to the reactviews folder? Currently, the files in the media folder are being copied directly into the VSIX, and the bundle also includes these files, causing duplication of resources.

Sure, I'll move them