Fixing bug where launching connection dialog from button can result in unpopulated webview

microsoft / vscode-mssql

Visual Studio Code SQL Server extension.

Other

1.53k stars 456 forks source link

Fixing bug where launching connection dialog from button can result in unpopulated webview #18083

Closed Benjin closed 3 days ago

Benjin commented 3 days ago

Fixes #18074

When opening the connection dialog from a VS Code view button (like the "+"), the command args are populated with info about the source button. After #18047, the args were assumed to be a valid connection info object, but needed to have a typeguard.

github-actions[bot] commented 3 days ago

VSIX Size Comparison

Main branch VSIX size: 11939 KB
PR branch VSIX size: 11939 KB
Size difference: $${\color{green} 0 KB \space (0\%) }$$
React Webview Bundle Size Comparison
Main branch bundle size: 2868 KB
PR branch bundle size: 2868 KB
Size difference: $${\color{green} 0 KB \space (0\%) }$$

microsoft / vscode-mssql

Fixing bug where launching connection dialog from button can result in unpopulated webview #18083

VSIX Size Comparison

React Webview Bundle Size Comparison