search

microsoft / vscode-mssql

Visual Studio Code SQL Server extension.
Other
1.55k stars 460 forks source link

[Rich Experiences] White Screen When Moving Query Results #18324

Open tmonoceros opened 3 weeks ago

tmonoceros commented 3 weeks ago

Steps to Reproduce:

  1. Enable "rich experiences" in settings.json "mssql.enableRichExperiences": true
  2. Execute any query

My results show up in the default "Query results" pane as expected (actual data removed from the screenshot)

Image

However, if I try to move the query results window to another pane, it goes completely white. Nothing I can do - not rerunning the query, not moving it back - seems to fix this.

Image

caohai commented 3 weeks ago

@tmonoceros Thanks for creating the issue!

move the query results window to another pane

Are you doing this via these options?

Here's what it looks like if I move the panel area to the right (tested on Mac and Windows)

tmonoceros commented 3 weeks ago

I was clicking and dragging to move the window. Here's a .gif showing this in action. I'm not moving the whole panel; I'm specifically moving the query results tab.

Image

caohai commented 3 weeks ago

@tmonoceros Thanks for the GIF, I was not aware of this drag and drop feature of panel tabs. I can confirm the repro, will take a look. Is the goal of this operation to have the QUERY RESULT pane on the right side while keeping the rest panel (Terminal/Output etc) at the bottom? Do you think this change we plan to make will improve your workflow? https://github.com/microsoft/vscode-mssql/issues/18316#issuecomment-2442827024

tmonoceros commented 3 weeks ago

I don't have a strong opinion on the exact fix right now. The fact that you're allowed to pop the query results out, but doing so breaks them and forces you to disable and reenable rich experiences to fix it, is a pretty clear bug that can actually be pretty disruptive. But it might just be muscle memory that causes me to prefer popping the query results out - that's how it works without Rich Experiences enabled, so that's what I'm used to.

I wouldn't complain (yet, anyway) if the fix was to just prevent the query results from being popped out. But if there's no reason to disallow popping the query results out (I don't know enough about the difference between editor panels and the rest panel to have an opinion there), seems like a straightforward win to me. I will say that everyone who starts using rich experiences will see this change in behavior, and so other people might have a stronger preference to be able to pop the results out to another panel.

caohai commented 3 weeks ago

The fact that you're allowed to pop the query results out, but doing so breaks them and forces you to disable and reenable rich experiences to fix it, is a pretty clear bug

The ability to pop the QUERY RESULT tab out of the vscode panel area and move this single tab into a document window(by drag-and-drop) comes from VSCode itself and I was not aware of this during until now. We'll look into the bug and hopefully get it fixed by next release.