[Rich Experience] Bad Query Result header readability on some themes

[atbraz]

• MSSQL Extension Version: 1.25.0
• VSCode Version: 1.95.0-insider
• OS Version: Win 11 Pro 23H2

Steps to Reproduce:

1. Use some non-default themes
2. Enable in settings.json "mssql.enableRichExperiences": true
3. Execute any query

On some themes (light and dark) the result header background and foreground colors make for some unreadable combinations.

Examples

Default (Readable)

Dark (Visual Studio)

Light (Visual Studio)

Non-Default Readable

Github Dark

Github Light

Red

Solarized Dark

Non-Default Unreadable (imo)

Monokai Pro (Filter Machine) - or almost any Monokai

Tomorrow Night Blue

Light High Contrast

Ayu Dark

[Benjin]

Thanks for bringing this to our attention!

@cssuh, do you think you'll be able to fix this for November, at least for the Light High Contrast theme? Seems we'll have to delve deeper into the many theme color options to make sure we're using combinations that are visible.

[Benjin]

We've fixed many theming issues across the extension with https://github.com/microsoft/vscode-mssql/pull/18347, which will be in our next release. Please open more issues if you find any other places where we have low contrast on some themes!

Monokai Pro (Filter Machine):

Tomorrow Night Blue:

Light High Constrast:

Ayu Dark: