search

microsoft / vscode-mssql

Visual Studio Code SQL Server extension.
Other
1.53k stars 455 forks source link

Unit tests for ConnectionService in SqlToolService #321

Closed benrr101 closed 7 years ago

benrr101 commented 7 years ago

After changes in a pending PR for unit tests, the code coverage for the ConnectionService/ReliableConnection stuff has reduced. We need to keep our code coverage high!

MitchellSternke commented 7 years ago

@benrr101 Do you know which methods you were calling from the connection service prior to the changes in your PR? This would help a lot with targeting which areas to hit.

MitchellSternke commented 7 years ago

Closing this since the coverage numbers for Connection Service have been above ~75% for a while now