microsoft / vscode-node-sqlite3

Asynchronous, non-blocking SQLite3 bindings for Node.js
BSD 3-Clause "New" or "Revised" License
34 stars 10 forks source link

fix: fix type-casting warnings #32

Closed rzhao271 closed 1 year ago

bpasero commented 1 year ago

@rzhao271 can we rather upstream these fixes to https://github.com/TryGhost/node-sqlite3? We try to stay on top of their changes.

deepak1556 commented 1 year ago

👍 on upstreaming.

rzhao271 commented 1 year ago

The upstream PR is still open and has not been merged. I fixed the merge conflicts for that PR but I'm still waiting for a response. Meanwhile, the Binskim issue is due next week for us. I suggest we get this PR merged first.