search

microsoft / vscode-notebook-renderers

MIT License
116 stars 36 forks source link

Exclude ansi-to-react from output #171

Closed DonJayamanne closed 1 year ago

DonJayamanne commented 1 year ago

Ensure we exclude ansi-to-react from output (ensure its not distributed) to address a CG issue We cannot remove ansi-to-react component as its a dependency of @nteract/transform package that is used, The next best is to just exclude from the output.

rgbkrk commented 1 year ago

Hey @DonJayamanne, I just started using the notebook in VS Code and am one of the maintainers on nteract. I'd love to get things into a great state for vs code. I'm loving the Notebook in VS Code. What's the CG issue?

DonJayamanne commented 1 year ago

@rgbkrk thanks got giving Notebook a try in VS Code,

I'd love to get things into a great state for vs code.

Love to hear this, thanks

What's the CG issue?

Basically the we (Jupyter extension and Notebooks in VS Code) rely on a built in mechanism for rendering markdown and stream output in VS Code, as a result the ansi-to-react package is not used. if the ansi-to-react library is used, then we had to update our repo to mention the usage of this package. To get around that I just excluded it from the build output, All in all, no problems with the package, just not used in any way (directly/indirectly)