search

microsoft / vscode-notebook-renderers

MIT License
115 stars 36 forks source link

Add support for image/webp #184

Closed BlackHC closed 1 year ago

BlackHC commented 1 year ago

webp is relatively new image format that is supported in VSCode again.

This very simple PR adds support for image/webp as mime type.

I've manually tested that it works with VSCode using the lastest release tag: https://github.com/BlackHC/vscode-notebook-renderers/releases/tag/v1.0.17%2Bwebp

HEAD currently independently throws Failed to resolve module specifier "ansi-to-react". when I try to load the compiled extension in VSCode.

BlackHC commented 1 year ago

@microsoft-github-policy-service agree

DonJayamanne commented 1 year ago

@BlackHC thanks for this PR, will discuss this with the team and get back.

DonJayamanne commented 1 year ago

@BlackHC Thanks, verified it works as expected. Fixed the issue with ansi-to-react in this PR https://github.com/microsoft/vscode-notebook-renderers/pull/185

BlackHC commented 1 year ago

Aww, thank you very much! This was super quick 🤗