microsoft / vscode-notebook-renderers

MIT License
116 stars 36 forks source link

ipywidgets do not respect color theme #212

Closed robtovey closed 2 months ago

robtovey commented 2 months ago

Duplicating https://github.com/tqdm/tqdm/issues/1457 because I think the issue lies in the vscode extensions rather than tqdm or ipywidgets.

Whenever I create a tqdm progress bar in a vscode notebook, it renders in "light mode" rather than matching the current theme. Having a play, it looks like this is also true for the underlying ipywidget.IntProgress object. For example: image image

This is on a fresh python environment with:

and vscode Jupyter=v2024.7.0 batch of extensions, of which I'm guessing the important one is notebook renderer=v1.0.19. My settings json has the line "workbench.preferredDarkColorTheme": "Default Dark Modern" The setting "jupyter.themeMatplotlibPlots": true/false has no effect.

Hopefully there is enough here for you to triage exactly which library/extension is at fault, I apologise if this is the wrong place for posting!

For context, there are also stack overflow questions for this as well:

There is some suggestion that vscode "can't theme ipywidgets", but I'm pretty sure JupyterLab manages it.

Thanks for your help

DonJayamanne commented 2 months ago

Duplicate of https://github.com/microsoft/vscode-jupyter/issues/7161