search

microsoft / vscode-notebook-renderers

MIT License
115 stars 36 forks source link

Replacing requirejs dependency with modern es6 imports #223

Open marthacryan opened 3 weeks ago

marthacryan commented 3 weeks ago

For a bit more context: https://github.com/requirejs/r.js/blob/1874a29ad51a395703629e3aece5d094a791b7ea/SECURITY.md

Requirejs is no longer actively maintained, and can be replaced with https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules. 

For example, see our removal of requirejs in plotly.py here: https://github.com/plotly/plotly.py/pull/4763

DonJayamanne commented 3 weeks ago

Thanks for the heads up. Not sure we can remove requirejs just yet, as ipywidgets depends on this, also the Renderers extension supports users with IPyWidgets 7 as well. From what I understand, keeping requirejs should not break plotly or anything else.

Basically all we'd need to do in this extension is ship the latest version of plotly, isn't that right?

gvwilson commented 2 weeks ago

Thanks very much @DonJayamanne - much appreciated.

gvwilson commented 2 days ago

hi @DonJayamanne - did you get a chance to look at this one? thanks - @gvwilson