search

microsoft / vscode-postgresql

PostgreSQL extension for VSCODE
Other
392 stars 50 forks source link

macos M1/arm64 to x64 runtime #110

Open dzsquared opened 2 years ago

dzsquared commented 2 years ago

Similar to this change: https://github.com/microsoft/vscode-mssql/pull/16969/files

fixes #104

Neokil commented 2 years ago

@akamath46297 can we have this PR merged soon? Current state of the Extension is unusable on MacOS

kinghuang commented 2 years ago

I hope this gets merged in. But, is anyone even maintaining this project? The last commit in master is from all the way back in April 2019! 😬

Neokil commented 2 years ago

due to the lack of activity I created a fork and fixed it there. Feel free to try it out and give feedback: https://marketplace.visualstudio.com/items?itemName=Neokil.vscode-postgresql-for-apple-m1

Inuart commented 1 year ago

@akamath46297 do you need to review this before merging?

ryboe commented 1 year ago

There's a native ARM64 version of SqlToolsService available for macOS now. It was part of the 1.42.0 (March 2023) release. I think we should use that on Apple Silicon Macs.

dzsquared commented 1 year ago

@ryboe - unfortunately for postgres, it is not part of sqltoolsservice. https://github.com/microsoft/pgtoolsservice