Regression or Purposeful Change? - PQTest.exe set-credential -ak Anonymous

bgribaudo commented 2 years ago

The 0.2.0 release removes the -ak Anonymous argument from the command line that is rendered out when setting an anonymous credential.

With 0.2.0, performing an anonymous credentials set results in the following being output:

[2:49:44 PM]    [Info]  [Task found] c:\Users\ben\.vscode\extensions\powerquery.vscode-powerquery-sdk-0.2.0-win32-x64\.nuget\Microsoft.PowerQuery.SdkTools.2.110.3\tools\PQTest.exe set-credential
                --extension "c:\Users\ben\Desktop\TestConnector\BenTest\bin\AnyCPU\Debug\BenTest.mez"
                --queryFile "c:\Users\ben\Desktop\TestConnector\BenTest\BenTest.query.pq"
                --prettyPrint

However, the picture associated with PR #160 shows the set credentials output as containing -ak Anonymous, making me suspect that that argument should still be rendered out. Should it?

bgribaudo commented 2 years ago

Related: #156

mattmasson commented 2 years ago

Are you hitting an error, or just a mismatch of what is included in the trace?

bgribaudo commented 2 years ago

No error. Just the trace output changed from 0.1.7 and is different from what the PR's screenshot showed.

albertli-msft commented 2 years ago

Hi Ben @bgribaudo :

This is not a regression, Matt enhanced it as we no longer need auth kind when a template string got provided. Thus, previously: Shown in screenshot of the last pr, there is a -ak argument. Currently, After https://github.com/microsoft/vscode-powerquery-sdk/pull/175 There won't be any -ak arguments since we recognized it as a template.

Thank Ben for finding this 😀, and i gonna close this ticket.

bgribaudo commented 2 years ago

Hi @albertli-msft,

That make sense: since a template is being used to define the anonymous credential, no -ak is required.

Thanks for all the work you are putting into this SDK!

Ben

microsoft / vscode-powerquery-sdk

Regression or Purposeful Change? - PQTest.exe set-credential -ak Anonymous #189