microsoft / vscode-powerquery

Visual Studio Code extension for Power Query / M.
MIT License
86 stars 16 forks source link

Functional no-op rewrite of how we generate libraries #220

Closed JordanBoltonMN closed 3 months ago

JordanBoltonMN commented 3 months ago

This update should be a functional no-op. It rewrites how we generate a library from a collection of symbols. For example, LibraryUtils.createLibrary now has the type signature:

createLibrary(
    staticLibraryDefinitionCollection: ReadonlyArray<ReadonlyArray<LibrarySymbol.LibrarySymbol>>,
    dynamicLibraryDefinitionCollection: ReadonlyArray<() => ReadonlyMap<string, Library.TLibraryDefinition>>,
)

The main things to look at are how we're generating it in SettingsUtils and follow the logic from there.