field access generalized identifiers highlight as seperate tokens

[ninmonkey]

Summary

This is minor: field access without quoted-identifiers highlight as separate tokens. ex: The textmate scope of in in [Records in Range] is a language keyword

I wasn't sure whether this is at the extension level or microsoft/powerquery-parser I put it here because even though textmate's scope is a keyword -- the parser seems to format correctly. I tried using a strange generalized-identifier to see if I could break the formatting, but it did not.

Power BI's editor has the same behaviour

Test Query

let
    Source = ...,
    #"Total Records1" = Table.AddColumn(
        Source, "Count 1",
        each Table.RowCount( [#"Records in Range"] ),
        type number
    ),
    #"Total Records2" = Table.AddColumn(
        Source, "Count 2",
        each Table.RowCount( [Records in Range] ),
        type number
    )

in
    #"Total Records2"

## I think this is the grammar involved (Expand)

. 

[mattmasson]

Yeah, this is an issue with our grammar file. In theory we could resolve it by enabling semantic highlighting via the powerquery-parser, but it should be pretty straightforward to resolve.

FWIW, we do have a separate github project for the language grammar (that has fallen out of date), but it does have some built in tests. I've been meaning to get it running again, but if anyone else wants to pick that up, please feel free :)

powerquery-language

/@JordanBoltonMN as FYI

[ninmonkey]

@mattmasson Which project is that?

[JordanBoltonMN]

@mattmasson Which project is that?

https://github.com/microsoft/powerquery-language