microsoft / vscode-pull-request-github

GitHub Pull Requests for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github
MIT License
2.31k stars 575 forks source link

Dozens of issues showing that are not from my repo, no issues from my repo are showing #1784

Closed ericblade closed 4 years ago

ericblade commented 4 years ago

Steps to Reproduce:

  1. Open a folder that currently contains a checkout of https://github.com/ericblade/quagga2
  2. Switch to the Github Pull Requests and Issues view

Results: image

None of these issues are from my github, they appear to be selected mostly at random, all but the first few with the same title are from different repos. Refreshing does not make any change.

I have no idea what other information I can provide to help diagnose, sorry.

ericblade commented 4 years ago

This has gone away now, I'm not sure if it was fixed in the point release of VSC, or if github fixed something, or if it was just some kind of transient error.

ericblade commented 4 years ago

Re-opening it, as the issue has resumed happening.

Am I the only person this is happening to? o.O

alexr00 commented 4 years ago

Do you have the setting githubIssues.queries set?

ericblade commented 4 years ago

I do not. I just upgraded to the latest VSC that came out yesterday/today, and it's getting stranger. Now most of my repos have a completely empty github view, even the Pull Requests side never populates, even though it should have a bunch of drop down thingees, even if there's nothing in them.

On this particular repo, though, it works -- but it's now giving me a completely different set of issues.

In attached screenshot, pull reqs are from this repo, but the issues appear to be taken from a completely random set of repos. Every one of them is from a different repo, there's not a pile of duplicates from the same, like there were last week when i looked.

image

alexr00 commented 4 years ago

That isn't how the default task query should look. It groups issues by Milestone. Can you share your all your settings.json?

ericblade commented 4 years ago

sure, this is the user settings.json

{
    "terminal.integrated.shell.windows": "C:\\WINDOWS\\System32\\cmd.exe",
    "editor.suggestSelection": "first",
    "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
    "workbench.colorTheme": "Visual Studio Dark",
    "git.autofetch": true,
    "enableTelemetry": false,
    "editor.minimap.enabled": false,
    "files.trimFinalNewlines": true,
    "files.trimTrailingWhitespace": true,
    "trailing-spaces.trimOnSave": true,
    "editor.fontFamily": "Fira Code, Consolas, 'Courier New', monospace",
    "editor.fontLigatures": true,
    "editor.fontSize": 13,
    "[html]": {
        "editor.defaultFormatter": "vscode.html-language-features"
    },
    "cSpell.userWords": [
        "ATVPDKIKX",
        "UPCE",
        "babel",
        "barcodes",
        "camelcase",
        "coalescing",
        "datapoints",
        "ericblade",
        "grayscale",
        "nullish",
        "operator",
        "plugin",
        "precoverage",
        "proposal",
        "quagga",
        "snyk"
    ],
    "javascript.updateImportsOnFileMove.enabled": "always",
    "remote.SSH.remotePlatform": {
        "arcade.lan": "windows"
    },
    "eslint.lintTask.enable": true
}

The workspace settings.json is empty.

alexr00 commented 4 years ago

I still can't reproduce what you're seeing. If you open the Source Control view, how many repos does it say you have open (screen shot would be good)? I opened a clone of the repo that you link in the original post, and this is what I see: image

ericblade commented 4 years ago

The Issue list here is now back to identical to what it was the first time I posted. :-S Is your screengrab there correct? Is "Created Issues" supposed to contain any open issues in the repo, or only things that You have created? If the former, there should be some 38 or so visible issues.

I'm not sure what view it is you're wanting a capture of -- I'm not aware of any views that show the information you're asking for, or exactly what information it is you're asking for, really.
The Source Control view only shows me a list of files with changes -- there are none

image

For all of my other code repos, the extension simply displays absolutely nothing -- completely empty on Pull Reqs and Issues. This is the only one I've got where it displays anything, and it's the wrong information.

alexr00 commented 4 years ago

When you have files from different repositories open, the Source Control viewlet will have two views: the one that you have a screenshot of (thanks, that's what I needed), and list of all the repositories you have opened (clearly not visible on yours indicating that you only have one repo open).

The default queries for the issues view are My Issues (issues that are assigned to you in the current repository, there are none for me in your repo), and Created Issues (issues that you created in the current repository, there are none from me in your repo). I have no explanation as to why you don't even see the My Issues and Created Issues headers.

Can you run the Developer: Toggle Developer Tools command and see if there's anything in the console there? Do you have any ideas as to what may be different or unexpected about your setup?

ericblade commented 4 years ago

... i really don't know ... but it does look like the brand new release today seems to have solved it, this repo, as well as the other two i have open right now, are all working as expected. previously, none of them did.

My Issues (issues that are assigned to you in the current repository, there are none for me in your repo), and Created Issues (issues that you created in the current repository, there are none from me in your repo)

different issue, but it does seem like it would be useful to have an option quickly available to display all issues .. not just ones that i created or were assigned to me.. though i suppose i could probably add a github action to auto-assign all issues to me.

alexr00 commented 4 years ago

an option quickly available to display all issues

You can always set "githubIssues.queries" to include all issues if the default queries don't work for you.

Mr-Pepe commented 4 years ago

Edit: Nevermind, I had the wrong repository open...

I originally used the following queries:

    "githubIssues.queries": [
        {
            "label": "My Issues",
            "query": "default"
        },
        {
            "label": "All Issues",
            "query": "state:open repo:${owner}/${repository} sort:created-desc"
        }
    ],

But that didn't yield any results for my repo (for neither of the queries), although there is one open issue created by me.

When I remove the repo filter I suddenly get many issues from random repositories as results for the "All Issues" query. When explicitly using repo:Mr-Pepe/stroke-order-animator I get the desired outcome.

Looks like the variables are not correctly set somehow!?

I start the editor with code --enable-proposed-api GitHub.vscode-pull-request-github.