Closed bpasero closed 2 years ago
This is a feature! If you're already in the browser (vscode.dev or github.dev), we create a vscode.dev or github.dev permalink instead of a github.com permalink.
This somewhat breaks my mental model because I use this action all the time on desktop to see a change in GH. My main reason for using GH is to see the git blame annotation and figure out the origin of a change.
Why can we not behave the same as we do on desktop, doesn't this result in weird inconsistencies with how commands work depending on where I am?
If a user is in vscode.dev or github.dev then they might prefer a vscode.dev or github.dev link over a github.com link since we already know that they link to use those. This is the justification for the copy permalink command.
For the open permalink command, I can see how this would not be useful in vscode.dev and github.dev. I can update the open command to not use the contextualized permalink.
👍
Opening a line on GitHub instead opens github.dev again.